Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra-check: 1.3.5 -> 2.0.1 #359514

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

doronbehar
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@bryango bryango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I (bryango) would also like to be a maintainer! Thank you!

It would probably be best to merge this after the bug fixes are merged upstream and a new patch release is made.

@doronbehar doronbehar changed the title hydra-check: 1.3.5 -> 2.0.0 hydra-check: 1.3.5 -> 2.0.1 Dec 21, 2024
@doronbehar doronbehar marked this pull request as ready for review December 21, 2024 16:00
@ofborg ofborg bot requested a review from bryango December 22, 2024 02:27
Copy link
Member

@bryango bryango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Built successfully on 3 platforms: https://github.com/bryango/nix-build-action/actions/runs/12454129774
aarch64-linux pending: https://github.com/bryango/nix-build-action/actions/runs/12454129776/job/34765045373

Tested binary on x86_64-linux, also good!

@doronbehar doronbehar merged commit 0648922 into NixOS:master Dec 22, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants